On Mon, 9 Mar 2015 23:41:55 +0100 [email protected] wrote: > I'll try to take a closer look at those and see if circular dependencies > can be reduced that way.
Since people are discussing code cleanups, here is a suggestion. We still have
a few type checking warning suppressions, which I always think of as a sign
that we have done something wrong.
* ListOption.readChild
* OptionGroup.setValue
* ListOptionUI.setCellRenderer
* Colony.getCorresponding
* Game.serverClass
The first three are awkward ones that I met when dealing with the Java
6->7 transition. I left them unfixed because I decided I needed
better understanding of the option handling code before fiddling with
them, and that it would probably require doing something smarter in
AbstractOption.readOption which is potentially destabilizing.
The last two are entirely my fault:-). When struggling with the
complexity of the AI colony planning code I invented getCorresponding
so that we could accurately copy a colony. serverClass() is a recent
hack to help recover from BR#2796, so urgency was the excuse there.
OTOH, I can report that IMHO all instances of
@SuppressWarnings("unused") are sensible and/or following a standard
convention, so please do not waste time chasing them.
Cheers,
Mike Pope
pgpYxI9_gzE5Q.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
