> Gesendet: Dienstag, 10. März 2015 um 11:56 Uhr > Von: "Michael T. Pope" <[email protected]> > An: [email protected], "FreeCol Developers" > <[email protected]> > Betreff: Re: [Freecol-developers] The size of dialogs > > On Tue, 10 Mar 2015 10:54:50 +0100 > [email protected] wrote: > >>[ColonyPanel] > > For me even as few as an estimated 60 pixels added to the panel width would > > alleviate the problem, with always having to resize it to have all buildings > > shown without scrollbars, most of the time. > > What needs to happen here is for the code that saves/restores panel sizes > from the client options to be kicked into working again. Then you (and > indeed, everyone) gets to set their dialog sizes to what they like, and it > stays that way, and we do not have to worry that much about the default > sizes. However I probably broke that code when dealing with the > FreeColDialog rewrite and have never got back to it. > > Cheers, > Mike Pope >
Hi, I did look at ColonyPanel code and it would be a 1 or 2 line change to make it a decent default size. That call, to the save method you mentioned, contains the default. The first statement in the constructor could also be adapted a bit. Now I know you said if the value could be saved everyone could just resize him/herself, but the panel is clearly too small for everyone, so a decent default would even in that case be better than all users resizing it once. From looking at the different parts there is no good way to internally free enough space. Maybe the borders/gaps could be removed, gaining maybe 20 pixels, for a slightly worse look. Otherwise either the maptiles would need to be shrunk, which is clearly bad, as they are 1:1 and look decently sized atm; or the building images would need to be shrunk, which would be a shame and a bad use of art. As a last ditch move we could look at the images if there is empty borders which could be cut off, but I doubt it. There is also BR#2655, which contains pictures illustrating the space problem. It looks like the height of the top line could profit from doubled height. Btw., I saw a suspicious "if (colonyUnitsMenu != null)" at line 723, which is always true, the same object is already used above and below it. I thought of deleting the line, but there may have been some other condition intended to include in there? Greetings wintertime ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
