Just a quick response to this, I am in a hurry right now. On Wed, 27 May 2015 23:30:39 +0200 Fenyo <feny...@gmail.com> wrote: > Take a look at Turn.toString()! > What is the problem with that? > The problem is that toString() also NEEDS a specification, and if the class > itself does not have it, that means toString() must acquire it as a parameter. > And why is that a problem? > Because toString() is defined in the Object class, and have to be overridden. > As you can see i have made it @Deprecated (and of course i defined an > overloaded version with one parameter), so the compiler will generate Warning > every time it is used. Because every single place it is used, we need to > append the specification parameter for toString().
I disagree strongly with this. Object is utterly fundamental. To me, if you find yourself trying to deprecate a routine inherited from it, that is a large red flag and flashing siren saying "You Are Doing It Wrong." IMHO a better way to achieve what you are trying to do is just invent new routine/s for turn display that take a spec parameter, or move the affected routines to somewhere like Game where the spec is already present. I repeat: Turn should just be essentially a wrapper for an integer. It is fine for its toString() routine to just become a simple debug helper like it is in many other classes, and lose its dependence on Season and its widespread use. Cheers, Mike Pope
pgpXavJalmpka.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
