On Thu, 28 May 2015 11:13:55 +0200 Fenyo <feny...@gmail.com> wrote: > Ok, you are saying that Turn.toString() should just convert the turn (the int) > to a String containing the turn number, without determining the season and > year? > That way it wouldn't need the spec. > Hmm, now i have looked on the points where an implicit Turn->String conversion > is done, and it seems they are all used for the logger only, and i have not > seen > any points where it is used for UI displaying.
OK, good. I was hoping it was not used much. > So it is likely that this change would not affect any of the UI displaying. > > Is it OK for you if I make this change, so the Turn.toString() > will just return an int converted to string? Go ahead on that. AFAICT Turn.toString(int) is then no longer needed. Meanwhile, I looked hard at Turn.java, and I think we can completely remove all references to the Season.* constants as long as Turn is told how many distinct seasons exist. I will check that soon, but again I am out of time. Cheers, Mike Pope
pgpZPjoMkcAjo.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
