>> Is it OK for you if I make this change, so the Turn.toString()
>> will just return an int converted to string?
> Go ahead on that. AFAICT Turn.toString(int) is then no longer needed.
Done:
https://sourceforge.net/u/fenyo1/freecol/ci/MoreSeasonsV3/
https://github.com/fenyo1/FreeCol/tree/MoreSeasonsV3
I have reduced HistoryEvent.toString() too, now it does not
use Turn.getYear(), it just uses Turn.toString() (implicitly)
And i have tested the whole thing, it is perfect.
> Meanwhile, I looked hard at Turn.java, and I think we can completely
> remove all references to the Season.* constants as long as Turn is told
> how many distinct seasons exist.
I am not sure, what do you mean by Season.* constants?
Is there anything else i can improve in this patch for you to accept?
Oh, i wanted to ask this:
What is the criteria that decides if a feature is Freecol 0.x or Freecol 2
material?
And why is it wrong if something gets into the game earlier?
Regards,
Fenyo
------------------------------------------------------------------------------
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers
