> I disagree strongly with this. Object is utterly fundamental. To me, if
> you find yourself trying to deprecate a routine inherited from it, that is
> a large red flag and flashing siren saying "You Are Doing It Wrong."
I completely agree. This is why i put Spec inside Turn.
> IMHO a better way to achieve what you are trying to do is just invent
> new routine/s for turn display that take a spec parameter, or move the
> affected routines to somewhere like Game where the spec is already
> present.
I think that is Turn.getLabel(), in V2 it already needs a spec parameter.
> I repeat: Turn should just be essentially a wrapper for an integer. It
> is fine for its toString() routine to just become a simple debug helper
> like it is in many other classes, and lose its dependence on Season and
> its widespread use.
Ok, you are saying that Turn.toString() should just convert the turn (the int)
to a String containing the turn number, without determining the season and year?
That way it wouldn't need the spec.
Hmm, now i have looked on the points where an implicit Turn->String conversion
is done, and it seems they are all used for the logger only, and i have not seen
any points where it is used for UI displaying.
So it is likely that this change would not affect any of the UI displaying.
Is it OK for you if I make this change, so the Turn.toString()
will just return an int converted to string?
Regards,
Fenyo
------------------------------------------------------------------------------
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers
