This has all been quite enlightening to see the difference in points of
view of Mike Pope, wintertime and mine. BTW, this email is more for Mr Weigelt
but may be of general interest. If you don't care about political BS,
disregard this email.
First a bit about me, so that you hopefully don't get the wrong impression.
I'm a developer at a small - med sized medical software firm in Canada. We
make middleware for ehealth. I, specificaly, work on a drug information
system. I've been here for 4 years. Before that, I did some web dev work.
All told, probably 7 years xp in software, so still kinda junior. I haven't
contributed actively to FreeCol for various reasons.
My questions are mostly about the perceived structure of the project and
the pain point uncovered.
First, my concern about the volume of email. I wasn't aware of the feature
in git to apply patches. I'll make a filter to delete them since I don't
really care what's in them. My main interest in this project is how issues
like this arise and are dealt with, as well as the pain points uncovered in
the architecture and technology used. Somewhat voyeuristic of me, i know. I
hope you'll forgive me.
Second, I highly respect experience and deep knowledge of Mr. Weigelt.
Given the opportunity, I would like to ask some questions.
It seems that you were offended by the lack of quality in the previous
commits, which is understandable. I doubt a project such as FreeCol
attracts ISO9000 style development.
How would you improve this? Should there also be test cases attached to
each patch, demonstrating an improvement? This too onerous?
re:"By the way: maybe it's just a language problem, but the term
"justifications"
sounds a bit like being tackled by a supervisor or a judge. Obviously,
we're all free men here, and nobody here has to justify himself for
another."
This is probably just being nitpicky of me. You are right in that we are
(or should be) all professionals here. I do wonder though, isn't there a
hierarchy in these projects? don't changes have to have enough
justification to warrant being added to the project? Doesn't the person who
ultimately accepts the pull request decide what makes it in and therefore
has to be justified to that person? If you don't think so, what is the
criteria for having code accepted?
Lastly, I've noticed that your contribution has focused on
'micro-optimizations', which I hope we can agree is an close enough term. I
can certainly sympathize. I've looked at code that manually parses a CSV
string and though 'gross'. It's hard to justify cleaning up such code,
since it works well enough for the project. How have you approached similar
changes to other projects? I find it's rarely worth the hassle. On the flip
side, https://en.wikipedia.org/wiki/Broken_windows_theory It seems finding
the balance is a matter of experience. Thoughts?
Regards,
Mike Berger
On Tue, Feb 14, 2017 at 6:37 AM Michael T. Pope <mp...@computer.org> wrote:
> On Tue, 14 Feb 2017 08:09:08 +0100
> "Enrico Weigelt, metux IT consult" <enrico.weig...@gr13.net> wrote:
> >...
>
> For the record I have no objection to patches being sent as emails to this
> list. The number of them is however unprecedented for FreeCol, which I
> would ask you to bear in mind.
>
> That said...
>
> > Like talking to an old kernel hacker,
>
> For a veteran of LKML, I am surprised that you appear to take offense
> quickly. freecol-developers is massively more civil than the flamings
> that pass routinely there. wintertime's question is of whose
> convenience is to be served here is a fair one to ask.
>
> > Looking at the repo history, it doesn't seem that the committers there
> > seem to care much.
>
> I have lost the thread of the argument here, but if you are referring to
> my inactivity with respect to your patches, beware that I am massively
> backlogged with my personal tree and more importantly, several bug reports
> have gone unanswered for longer than I prefer. That said, your "player
> optimize visibility" patch is now about 3rd in line for testing.
>
> > Actually, I did a few profilings, but it's hard to get any useful
> > numbers, as the jitter is just too high, and it's just not worth
> > the effort und patch-by-patch basis.
>
> Cool. Do you now see why I am sceptical of the patches that I have
> been labelling "microoptimizations"?
>
> What I still want to know about is why you are experiencing a huge
> slowdown, as discussed before.
>
> > OTOH, as an seasoned sw-engineer...
>
> Here you are out of line. This is not a place where we indulge in
> credential wars. Respect is gained by making useful contributions to
> FreeCol. I hope you can find a way to do so that balances the
> convenience of all contributors with your own.
>
> Cheers,
> Mike Pope
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Freecol-developers mailing list
> Freecol-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freecol-developers
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers
