On Tue, 11 Mar 2008 21:11:23 +0100 Dominik Vogt <[EMAIL PROTECTED]> wrote:
> > New patch attached. If this is ok, do you agree to add a 3rd parameter > > to add margins above AND below the separators? > > I'd rather have a more generic way to configure the looks of the > separators (that maybe includes the FlatSeparators stuff from a > different thread). I just though that they were related items. But I'll do as you wish, all in all, what I really care is about the functionality being there. I am not that picky about the semantics and the syntax. > The current patch looks (almost) fine (see comment below) and I'd > like to apply it. When you write the documentation, don't forget > to add an entry to the ChangeLog vor every file and function you > change. Sure, count on it. That's a task for tomorrow ;) > > diff -r -U5 fvwm/fvwm/menus.c fvwm/fvwm/menus.c > > --- fvwm/fvwm/menus.c 2008-03-11 17:09:42.000000000 +0100 > > +++ fvwm/fvwm/menus.c 2008-03-11 18:02:52.000000000 +0100 > > @@ -1601,11 +1603,11 @@ > > int separator_height; > > > > separator_height = (last_item_has_relief) ? > > MENU_SEPARATOR_HEIGHT + relief_thickness : > > MENU_SEPARATOR_TOTAL_HEIGHT; > > - MI_Y_OFFSET(mi) = y; > > + MI_Y_OFFSET(mi) = y + MST_VERTICAL_MARGIN_BOTTOM(msp->menu); > ^^^^^^ > > Shouldn't this be the top margin? > Yes *slaps himself on the face*. I am not sure why I wrote that :P It must have been some copy/paste issue or something like that. Thanks for all the guidance. I will attach a complete patch as soon as I have the time to finish it. By the way, above you said that you couldn't add functionality like this a couple of years ago. Can you comment a few words on that? Is it maybe that the thing was somewhat more obscure or something? Has there been any massive cleaning the last few years? -- Jesús Guerrero <[EMAIL PROTECTED]>