Hi,

Richard Biener <richard.guent...@gmail.com> writes:

> [snip]
>> I was also proposing (and would like to re-air that here) enforcing
>> that the committer field of each commit is a (valid) @gcc.gnu.org
>> email.  This can be configured repo-locally via:
>>
>>   $ git config committer.email <yourname>@gcc.gnu.org
>>
>> Git has supported this since 39ab4d0951ba64edcfae7809740715991b44fa6d
>> (v2.22.0).
>>
>> This makes a permanent association of each commit to its authors
>> Sourceware account.
>
> I'd welcome this - care to create a patch for
> contrib/gcc-git-customization.sh?

Sure - I've attached a partial patch.  I didn't find the hook which runs
on each push to check commits, so the current patch is minimal.  Is that
also in the tree?  I could try hacking it to check commits.
-- 
Arsen Arsenović
From c7ca9e26693a707a0aa9f87aeb35717f5fecdc79 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <ar...@aarsen.me>
Date: Tue, 25 Jun 2024 20:57:34 +0200
Subject: [PATCH] git-customizations: set committer email to @gcc.gnu.org email

See discussion at
https://inbox.sourceware.org/gcc/87y16uowix....@gentoo.org/

contrib/ChangeLog:

        * gcc-git-customization.sh: Set committer.email to
        remote...@gcc.gnu.org.
---
 contrib/gcc-git-customization.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/contrib/gcc-git-customization.sh b/contrib/gcc-git-customization.sh
index 54bd35ea1aab..9e23e71f4204 100755
--- a/contrib/gcc-git-customization.sh
+++ b/contrib/gcc-git-customization.sh
@@ -129,6 +129,7 @@ fi
 
 ask "Account name on gcc.gnu.org (for your personal branches area)" 
"$remote_id" remote_id
 git config "gcc-config.user" "$remote_id"
+git config "committer.email" "${remote_id}@gcc.gnu.org"
 
 old_pfx=$(git config --get "gcc-config.userpfx")
 if [ "x$old_pfx" = "x" ]
-- 
2.45.2

Attachment: signature.asc
Description: PGP signature

Reply via email to