On 24/06/2024 23:34, Arsen Arsenović via Gcc wrote: > Hi, > > Sam James via Gcc <gcc@gcc.gnu.org> writes: > >> Hi! >> >> This comes up in #gcc on IRC every so often, so finally >> writing an RFC. >> >> What? >> --- >> >> I propose that MAINTAINERS be modified to be of the form, >> adding an extra field for their GCC/sourceware account: >> <Name> <Email> <Email on gcc.gnu.org BZ / sourceware >> account> >> Joe Bloggs joeblo...@example.com jblo...@gcc.gnu.org >> >> Further, that the field must not be blank (-> must have a BZ account; >> there were/are some without at all)! >> >> Why? >> --- >> >> 1) This is tied to whether or not people should use their committer email >> on Bugzilla or a personal email. A lot of people don't seem to use their >> committer email (-> no permissions) and end up not closing bugs, so >> pinskia (and often myself these days) end up doing it for them. >> >> 2) It's standard practice to wish to CC the committer of a bisect result >> - or to CC someone who you know wrote patches on a subject area. Doing >> this on Bugzilla is challenging when there's no map between committer >> <-> BZ account. >> >> Specifically, there are folks who have git committer+author as >> joeblo...@example.com (or maybe even coold...@example.com) where the >> local part of the address has *no relation* to their GCC/sw account, >> so finding who to CC is difficult without e.g. trawling through gcc-cvs >> mails or asking overseers for help. > > I was also proposing (and would like to re-air that here) enforcing that > the committer field of each commit is a (valid) @gcc.gnu.org email. > This can be configured repo-locally via: > > $ git config committer.email <yourname>@gcc.gnu.org > > Git has supported this since 39ab4d0951ba64edcfae7809740715991b44fa6d > (v2.22.0). > > This makes a permanent association of each commit to its authors > Sourceware account. > > This should not inhibit pushes, as the committer should be a reflection > of who /applied/ a patch, and anyone applying a patch that can also push > has a Sourceware account. It also should not inhibit any workflow, as > it should be automatic.
I think this presumes a strict 'git apply' model for incorporating patches from mailing lists, but what about contributors who do not have a sourceware account and rely on another developer to fetch from their tree and push it afterwards (eg the linux bubble-up model)? In that case the patch fetched will show the original author as the committer. R. > >> Summary >> --- >> >> TL;DR: The proposal is: >> >> 1) MAINTAINERS should list a field containing either the gcc.gnu.org >> email in full, or their gcc username (bikeshedding semi-welcome); >> >> 2) It should become a requirement that to be in MAINTAINERS, one must >> possess a Bugzilla account (ideally using their gcc.gnu.org email). >
