----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2851/#review6481 -----------------------------------------------------------
src/cpu/o3/cpu.cc (line 295) <http://reviews.gem5.org/r/2851/#comment5557> Wouldn't it be easier to just initialize the zero register index here using freeList.getIntReg() instead of doing it in the loop? src/cpu/o3/cpu.cc (line 300) <http://reviews.gem5.org/r/2851/#comment5558> If you initialize the zero register earlier, this would become: const PhysRegIndex phys_reg = ridx != TheISA::ZeroReg ? freeList.getIntReg() : zero_phys_reg; Looks functionally OK. Feel free to submit without another review round if you change the issue above. - Andreas Sandberg On May 28, 2015, 4:38 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2851/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 4:38 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10859:9c783a1367cd > --------------------------- > cpu: o3: Mapping the ZeroRegister for all hardware threads > This patch helps enabling SMT in x86 by mapping the ZeroRegister to one > physical register across all hardware threads. > > > Diffs > ----- > > src/cpu/o3/cpu.cc d02b45a554b52c68cce41e1b3895fb8582a639dd > > Diff: http://reviews.gem5.org/r/2851/diff/ > > > Testing > ------- > > Quick regressions passed for all ISAs. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
