----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2986/#review7380 -----------------------------------------------------------
You need to add copyrights to all the new files that are being added. configs/common/HMC.py (line 49) <http://reviews.gem5.org/r/2986/#comment6229> Why do we need to derive HMCSystem from SubSystem? configs/example/fs.py (lines 220 - 223) <http://reviews.gem5.org/r/2986/#comment6230> I think all of this code should be in MemConfig.py. configs/example/hmctest.py (line 1) <http://reviews.gem5.org/r/2986/#comment6231> Drop this file. Sooner or later it would become out of date. Instead add a new regression test for HMC. - Nilay Vaish On Oct. 15, 2015, 7:10 a.m., Erfan Azarkhish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2986/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 7:10 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11174:66717cb1efa8 > --------------------------- > mem: Simple HMC Model > > This patch enables modeling a complete Hybrid Memory Cube (HMC) device. It > highly reuses the existing components in gem5's general memory system with > some small modifications. This changeset requires an additional patch (2993) > for modeling the serial links. > > > Diffs > ----- > > src/mem/HMCController.py PRE-CREATION > src/mem/SConscript 3a4d1b5cd05c > src/mem/hmc_controller.hh PRE-CREATION > src/mem/hmc_controller.cc PRE-CREATION > src/mem/xbar.hh 3a4d1b5cd05c > configs/common/MemConfig.py 3a4d1b5cd05c > configs/example/fs.py 3a4d1b5cd05c > configs/example/hmctest.py PRE-CREATION > src/mem/DRAMCtrl.py 3a4d1b5cd05c > configs/common/HMC.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/2986/diff/ > > > Testing > ------- > > gem5 compiles > fs.py executes and Linux boots correctly. > hmctest.py executes correctly, and stats correlate with cycle-accurate > simulation > > > Thanks, > > Erfan Azarkhish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
