> On Oct. 16, 2015, 2:53 p.m., Nilay Vaish wrote: > > configs/example/hmctest.py, line 1 > > <http://reviews.gem5.org/r/2986/diff/7/?file=50322#file50322line1> > > > > Drop this file. Sooner or later it would become out of date. Instead > > add a new regression test for HMC.
As you said, I dropped this file. I will add the regression test later in a separate patch. Because I don't know how to do it yet. > On Oct. 16, 2015, 2:53 p.m., Nilay Vaish wrote: > > configs/common/HMC.py, line 49 > > <http://reviews.gem5.org/r/2986/diff/7/?file=50319#file50319line49> > > > > Why do we need to derive HMCSystem from SubSystem? My goal has been to improve modularity, readability of the stats, and visualization of the HMC device. Also, based on HMC specs it should be possible to instantiate multiple HMC devices and connect them to each other in different forms. I think having HMC as a subsystem can be helpful for the mentioned reasons. - Erfan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2986/#review7380 ----------------------------------------------------------- On Oct. 15, 2015, 7:10 a.m., Erfan Azarkhish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2986/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 7:10 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11174:66717cb1efa8 > --------------------------- > mem: Simple HMC Model > > This patch enables modeling a complete Hybrid Memory Cube (HMC) device. It > highly reuses the existing components in gem5's general memory system with > some small modifications. This changeset requires an additional patch (2993) > for modeling the serial links. > > > Diffs > ----- > > src/mem/HMCController.py PRE-CREATION > src/mem/SConscript 3a4d1b5cd05c > src/mem/hmc_controller.hh PRE-CREATION > src/mem/hmc_controller.cc PRE-CREATION > src/mem/xbar.hh 3a4d1b5cd05c > configs/common/MemConfig.py 3a4d1b5cd05c > configs/example/fs.py 3a4d1b5cd05c > configs/example/hmctest.py PRE-CREATION > src/mem/DRAMCtrl.py 3a4d1b5cd05c > configs/common/HMC.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/2986/diff/ > > > Testing > ------- > > gem5 compiles > fs.py executes and Linux boots correctly. > hmctest.py executes correctly, and stats correlate with cycle-accurate > simulation > > > Thanks, > > Erfan Azarkhish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
