> On Oct. 16, 2015, 2:53 p.m., Nilay Vaish wrote: > > configs/common/HMC.py, line 49 > > <http://reviews.gem5.org/r/2986/diff/7/?file=50319#file50319line49> > > > > Why do we need to derive HMCSystem from SubSystem? > > Erfan Azarkhish wrote: > My goal has been to improve modularity, readability of the stats, and > visualization of the HMC device. > Also, based on HMC specs it should be possible to instantiate multiple > HMC devices and connect them to each other in different forms. > I think having HMC as a subsystem can be helpful for the mentioned > reasons. > > Nilay Vaish wrote: > Somehow I still do not like the current organization. But I am failing to > come with anything better. So I'll take what you have. > > Andreas Hansson wrote: > I think a SubSystem is a great way of accomplishing modularity here. We > don't use it enough imho. What is your reservation Nilay?
SubSystem does not have any configuration params, which means it is same as having a SimObject. As of now, I don't see any use for SubSystem. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2986/#review7380 ----------------------------------------------------------- On Oct. 18, 2015, 4:31 p.m., Erfan Azarkhish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2986/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2015, 4:31 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11174:6e02b2208e16 > --------------------------- > mem: Simple HMC Model > > This patch enables modeling a complete Hybrid Memory Cube (HMC) device. It > highly reuses the existing components in gem5's general memory system with > some small modifications. This changeset requires an additional patch (2993) > for modeling the serial links. > > > Diffs > ----- > > configs/common/HMC.py PRE-CREATION > configs/common/MemConfig.py 3a4d1b5cd05c > configs/example/fs.py 3a4d1b5cd05c > src/mem/DRAMCtrl.py 3a4d1b5cd05c > src/mem/HMCController.py PRE-CREATION > src/mem/SConscript 3a4d1b5cd05c > src/mem/hmc_controller.hh PRE-CREATION > src/mem/hmc_controller.cc PRE-CREATION > src/mem/xbar.hh 3a4d1b5cd05c > > Diff: http://reviews.gem5.org/r/2986/diff/ > > > Testing > ------- > > gem5 compiles > fs.py executes and Linux boots correctly. > hmctest.py executes correctly, and stats correlate with cycle-accurate > simulation > > > Thanks, > > Erfan Azarkhish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
