> On May 25, 2016, 8:01 a.m., Andreas Hansson wrote: > > src/dev/net/etherswitch.cc, line 347 > > <http://reviews.gem5.org/r/3465/diff/7/?file=55548#file55548line347> > > > > I would say we either need to allow for these to be optional (there is > > a macro for that if I remember correctly), or alternatively the > > cpt_upgrader.py in util needs to be updated and add the field.
I've added a cpt_upgrader to fix this issue. - Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3465/#review8338 ----------------------------------------------------------- On May 30, 2016, 2:46 a.m., Mohammad Alian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3465/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 2:46 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11472:7977ab53fb94 > --------------------------- > dist, dev: Fixed the packet ordering in etherswitch > This patch fixes the order that packets gets pushed into the output fifo > of etherswitch. If two packets arrive at the same tick to the etherswitch, > we sort and push them based on their source port id. > In dist-gem5 simulations, if there is no ordering inforced while two > packets arrive at the same tick, it can lead to non-deterministic simulations > > > Diffs > ----- > > src/dev/net/etherswitch.hh 954d3014f7f0 > src/dev/net/etherswitch.cc 954d3014f7f0 > util/cpt_upgraders/etherswitch.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/3465/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Alian > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
