> On May 24, 2016, 10 p.m., Andreas Hansson wrote: > > src/dev/net/etherswitch.cc, line 93 > > <http://reviews.gem5.org/r/3465/diff/7/?file=55548#file55548line93> > > > > should this perhaps even be a warn (or do we ever expect this to happen > > in a correct setup? > > Mohammad Alian wrote: > I would say It can happen in a correct setup. If someone set the fifo > size of the ethernet switch smaller than MTU of ethernet packets then it > would happen. But I can change it to warn if you think it's better. > > Andreas Hansson wrote: > I think a warn is better. If someone "misconfigures" the system they will > not have a clue with the current DPRINTF unless they run with the very > speficic flag. Agreed?
Agree. I changed it to warn. - Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3465/#review8336 ----------------------------------------------------------- On May 30, 2016, 1:32 p.m., Mohammad Alian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3465/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 1:32 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11472:d97d6bf2206b > --------------------------- > dist, dev: Fixed the packet ordering in etherswitch > This patch fixes the order that packets gets pushed into the output fifo > of etherswitch. If two packets arrive at the same tick to the etherswitch, > we sort and push them based on their source port id. > In dist-gem5 simulations, if there is no ordering inforced while two > packets arrive at the same tick, it can lead to non-deterministic simulations > > > Diffs > ----- > > src/dev/net/etherswitch.hh 954d3014f7f0 > src/dev/net/etherswitch.cc 954d3014f7f0 > util/cpt_upgraders/etherswitch.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/3465/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Alian > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
