You can go ahead, Sandipan. Since my series has fairly broad impact, I'm thinking I'll wait until after the release to check it in.
Gabe On Thu, Feb 25, 2021 at 12:08 AM Sandipan Das <[email protected]> wrote: > Hi Gabe, > > On 25/02/21 1:10 pm, Gabe Black wrote: > > Hi Sandipan. You are correct, except that I would say you don't need to > > force push, just regular push. If I were at the head of a branch I wanted > > to (re)upload to gerrit, I would run: > > > > git push origin HEAD:refs/for/develop > > > > Gerrit will look at the Change-Id field in the commit message and use > that > > to identify reviews. If one already exists, it will create a new patchset > > version (you can look at and compare them in the review UI if you like), > > and if it doesn't it will make a new review. In the output of the git > > command it will tell you which ones are new and which ones are updated if > > you're curious. > > > > While it can be mildly disorienting clicking around a series where the > > ordering of reviews has changed (gerrit tries to go off of the patchset > > version you're currently looking at), it has no problem keeping track of > > everything. > > > > Great. Thanks! > I have made amends for most of the current review comments. As soon as > your register class related changes are merged, I will rebase my patches > and push them. > > - Sandipan >
_______________________________________________ gem5-dev mailing list -- [email protected] To unsubscribe send an email to [email protected] %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
