Yes, Steve's got it right. In the C++ you replace the instances of the 3 lengths Nate mentions with a single var (that can be more aptly named as Steve wants) that is pythonically calculated and passed in from the configuration. I'm making up words here :).
I think I can do this tonight or tomorrow, I don't think it's that complicated, so yes, I'm healthy enough :). Lisa On Tue, Apr 19, 2011 at 3:58 PM, Steve Reinhardt <ste...@gmail.com> wrote: > I think Lisa's "pythonic fix" is the one where we use the _numCpus > value that's calculated entirely in python (including the +1 offset in > FS mode) and don't attempt the automatic C++ technique that Korey > proposed. Yes, that still involves C++ changes, specifically making > everything in the C++ code just use the value passed in from python. > That value is currently called _numCpus. IMO, _numCpus is not a good > name, and while we're at it we should change it to be more > descriptive, like _numSharers or _numSharingContexts. > > Steve > > On Tue, Apr 19, 2011 at 3:14 PM, Korey Sewell <ksew...@umich.edu> wrote: > > I think "_numCpus+1" is the safe choice....Lisa? > > > > On Tue, Apr 19, 2011 at 6:01 PM, nathan binkert <n...@binkert.org> > wrote: > >>> I think the immediate fix is the pythonic fix from a few msgs ago. I > >>> believe that's quick and easy. I think :). > >> > >> The fix has to be more than python. I'm talking about the original > >> question. The stats use three different lengths: "_numCpus + 1", > >> "_numCpus", > >> or "maxThreadsPerCPU". Which one is correct? > >> > >> Are you healthy enough to fix this? > >> > >> Thanks, > >> > >> Nate > >> _______________________________________________ > >> m5-dev mailing list > >> m5-dev@m5sim.org > >> http://m5sim.org/mailman/listinfo/m5-dev > >> > > > > > > > > -- > > - Korey > > _______________________________________________ > > m5-dev mailing list > > m5-dev@m5sim.org > > http://m5sim.org/mailman/listinfo/m5-dev > > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
