Hi,

One issue I see with the instructions script is that you are asking people to 
download it from head, this may make it hard to verify old releases or may give 
different results during the voting process if changes are made. It may be 
better to package the verifying script inside the release candidate.

Another is from the output of the script it’s unclear where it downloaded the 
files or what rc it is testing, adding that may be useful. It also clones 
incubator-openwhisk-utilities which might be seen as misleading as should it be 
cloning incubator-openwhisk-composer so it can compare what’s in version 
control to what in the release candidate. Again this seem to be checking out 
head which would change over time so it might be possible for it to give 
inconstant results.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to