On Wed, 24 Apr 2024 at 08:29, Shawn Yang <shawn.ck.y...@gmail.com> wrote: > > Hi Sebb, > > I highlight that the current release is not an asf release in the install > page in PR https://github.com/apache/incubator-fury-site/pull/113. > > Could you take a look at it again?
I have just looked at the PR you just raised, and it looks OK. Note that my comment was about the published install page, which is still as I described. > Thanks for taking time to review Fury's release. > > Best regards, > Chaokun Yang > > On Wed, Apr 24, 2024 at 3:20 PM sebb <seb...@gmail.com> wrote: > > > There is now a link to a potential download page, which is great. > > > > However, the install page does not make it obvious that the 0.4.1 > > release is not an ASF release. > > That information should be shown prominently at the start of the page, > > not buried in a note near the end. > > > > On Tue, 23 Apr 2024 at 16:07, Shawn Yang <shawn.ck.y...@gmail.com> wrote: > > > > > > I updated it in the PR > > > https://github.com/apache/incubator-fury-site/pull/112. Sorry for my > > last > > > reply, I forgot to put the PR link. > > > > > > On Tue, Apr 23, 2024 at 10:22 PM sebb <seb...@gmail.com> wrote: > > > > > > > On Tue, 23 Apr 2024 at 14:05, Shawn Yang <shawn.ck.y...@gmail.com> > > wrote: > > > > > > > > > > Hi Sebb, > > > > > > > > > > I updated the content in the install doc and added notes that this > > is > > > > not > > > > > an ASF release. > > > > > > > > > > And added a download page for download and verify source release > > only. > > > > > Currently this page is basically empty, but will be updated once this > > > > vote > > > > > is done, and updated > > > > > to closer.lua according to download-scripts[1]. > > > > > > > > > > The cross-links to each other are also added. > > > > > > > > I don't see these changes on the fury.apache.org website. > > > > Are they published anywhere? > > > > > > > > > 1. > > https://infra.apache.org/release-download-pages.html#download-scripts > > > > > > > > > > Thanks again for pointing those issues out. > > > > > > > > > > --------- > > > > > Best Regards, > > > > > Chaokun Yang > > > > > > > > > > On Tue, Apr 23, 2024 at 8:22 PM sebb <seb...@gmail.com> wrote: > > > > > > > > > > > On Tue, 23 Apr 2024 at 13:08, tison <wander4...@gmail.com> wrote: > > > > > > > > > > > > > > > They could fix the page now, while waiting for the release > > vote to > > > > > > > complete. > > > > > > > > > > > > > > Make sense. At least remove the page/content now to indicate "no > > > > Apache > > > > > > > release" now. Then it won't be some "forth and back" updates. > > It's a > > > > > > timing > > > > > > > issue. > > > > > > > > > > > > > > > Note that the page needs more than just an update to version > > > > numbers. > > > > > > > > It needs closer.lua links to the source bundle, links to KEYS, > > sigs > > > > > > > > and hashes, and verification instructions. > > > > > > > > > > > > > > Such an install page can be a simplified quick start page. I > > suppose > > > > you > > > > > > > refer to a download page like [1]. > > > > > > > > > > > > > > [1] https://hadoop.apache.org/releases.html > > > > > > > > > > > > Yes, though ideally use closer.lua rather than closer.cgi. > > > > > > > > > > > > > And yes, Fury doesn't have a download page yet, and they should > > add > > > > one. > > > > > > > > > > > > Agreed. > > > > > > > > > > > > > But in my experience it's different from a quickstart install > > page, > > > > like > > > > > > > [2] vs [3]. > > > > > > > > > > > > Yes, but that should not be at the expense of a source download > > page. > > > > > > It must be easy to find the source download. > > > > > > The website and the announcement email must link to the official > > > > download > > > > > > page. > > > > > > > > > > > > The download and install pages could be cross-linked. > > > > > > > > > > > > > [2] https://opendal.apache.org/docs/quickstart#java-binding > > > > > > > [3] https://opendal.apache.org/download > > > > > > > > > > > > > > Best, > > > > > > > tison. > > > > > > > > > > > > > > > > > > > > > sebb <seb...@gmail.com> 于2024年4月23日周二 20:00写道： > > > > > > > > > > > > > > > On Tue, 23 Apr 2024 at 12:46, tison <wander4...@gmail.com> > > wrote: > > > > > > > > > > > > > > > > > > > I would be very disappointed if the podling published the > > code > > > > > > > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > > > > > > > > > > > IIUC Fury will update the content and delete all the > > references > > > > to > > > > > > prior > > > > > > > > > releases. > > > > > > > > > > > > > > > > Note that the page needs more than just an update to version > > > > numbers. > > > > > > > > It needs closer.lua links to the source bundle, links to KEYS, > > sigs > > > > > > > > and hashes, and verification instrructions. > > > > > > > > > > > > > > > > > Or instead, Fury can keep these references and state clearly > > it's > > > > > > prior > > > > > > > > > releases. > > > > > > > > > > > > > > > > > > My comment above is with an assumption that prior releases > > ref > > > > will > > > > > > be > > > > > > > > > removed. But if the PPMC wants to keep it, they should > > update the > > > > > > > > > description. > > > > > > > > > > > > > > > > They could fix the page now, while waiting for the release > > vote to > > > > > > > > complete. > > > > > > > > > > > > > > > > > Best, > > > > > > > > > tison. > > > > > > > > > > > > > > > > > > > > > > > > > > > sebb <seb...@gmail.com> 于2024年4月23日周二 19:35写道： > > > > > > > > > > > > > > > > > > > On Tue, 23 Apr 2024 at 09:42, tison <wander4...@gmail.com> > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > There is no indication that 0.4.1 is not an ASF > > release. > > > > > > > > > > > > > > > > > > > > > > You may found that the group id is not org.apache.fury > > also. > > > > > > > > > > > > > > > > > > > > Whilst this is true, it is still not obvious that this is > > not > > > > an > > > > > > ASF > > > > > > > > > > release; it is easy to overlook this minor detail. > > > > > > > > > > > > > > > > > > > > Indeed, there is no such indication for the GoLang, > > Javascript > > > > or > > > > > > Rust > > > > > > > > > > binaries. > > > > > > > > > > > > > > > > > > > > > This is an intermediate state that we would update the > > > > content > > > > > > as: > > > > > > > > > > > > > > > > > > > > > > <dependency> > > > > > > > > > > > <groupId>org.apache.fury</groupId> > > > > > > > > > > > <artifactId>fury-core</artifactId> > > > > > > > > > > > <version>0.5.0</version> > > > > > > > > > > > </dependency> > > > > > > > > > > > > > > > > > > > > > > And then the content is correct. > > > > > > > > > > > > > > > > > > > > Strictly speaking the content of the Maven reference to > > 0.4.1 > > > > is > > > > > > not > > > > > > > > > > 'incorrect'. > > > > > > > > > > The problem is that the page does not make it clear that > > the > > > > > > release > > > > > > > > > > is not an ASF release. > > > > > > > > > > > > > > > > > > > > It's OK to refer to prior releases, but the reader must be > > > > clearly > > > > > > > > > > informed of their provenance. > > > > > > > > > > > > > > > > > > > > > If we make any workaround or patch to make > > > > > > > > > > > it "look good", it would be updated as soon as 0.5.0 is > > > > > > released. So > > > > > > > > I > > > > > > > > > > > won't treat that as a release blocker. > > > > > > > > > > > > > > > > > > > > I would be very disappointed if the podling published the > > code > > > > > > > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > tison. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > sebb <seb...@gmail.com> 于2024年4月23日周二 15:59写道： > > > > > > > > > > > > > > > > > > > > > > > On Mon, 22 Apr 2024 at 10:11, PJ Fanning < > > > > fannin...@apache.org > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > Hi Sebb, > > > > > > > > > > > > > This email thread is a vote for an RC. If this vote > > > > passes, > > > > > > > > v0.5.0 > > > > > > > > > > > > > will be the first release of Fury since it became a > > > > podling. > > > > > > > > > > > > > We will add a download page but at the moment, there > > is > > > > > > nothing > > > > > > > > to > > > > > > > > > > > > > link to there (except perhaps a KEYS file). > > > > > > > > > > > > > > > > > > > > > > > > > > The Install page does need to be updated to not > > mention > > > > > > > > snapshots. > > > > > > > > > > > > > > > > > > > > > > > > If 0.5.0 is to be the first ASF release, then the > > Install > > > > page > > > > > > is > > > > > > > > very > > > > > > > > > > > > misleading. > > > > > > > > > > > > > > > > > > > > > > > > There is no indication that 0.4.1 is not an ASF > > release. > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > PJ > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, 22 Apr 2024 at 10:35, sebb <seb...@gmail.com > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang < > > > > > > > > shawn.ck.y...@gmail.com> > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hello everyone, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This is a call for the vote to release Apache > > > > > > > > Fury(Incubating) > > > > > > > > > > > > v0.5.0-rc3. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The Apache Fury community has voted and approved > > the > > > > > > release > > > > > > > > of > > > > > > > > > > > > Apache > > > > > > > > > > > > > > > Fury(incubating) v0.5.0-rc3. We now kindly > > request > > > > the > > > > > > IPMC > > > > > > > > > > members > > > > > > > > > > > > > > > review and vote for this release. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Apache Fury(incubating) - A blazingly fast > > > > multi-language > > > > > > > > > > > > serialization > > > > > > > > > > > > > > > framework powered by JIT and zero-copy. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Fury community vote thread: > > > > > > > > > > > > > > > > > > > > > > > > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Vote result thread: > > > > > > > > > > > > > > > > > > > > > > > > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The release candidate: > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This release has been signed with a PGP available > > > > here: > > > > > > > > > > > > > > > https://downloads.apache.org/incubator/fury/KEYS > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I could not find a proper download page for the > > > > release. > > > > > > > > > > > > > > This must have links to the source bundle which > > must > > > > use > > > > > > > > > > closer.lua, > > > > > > > > > > > > > > as well as links to KEYS, sigs and hashes, with > > > > > > instructions on > > > > > > > > > > how to > > > > > > > > > > > > > > validate downloads. > > > > > > > > > > > > > > > > > > > > > > > > > > > > There is an install page on the website at > > > > > > > > > > > > > > https://fury.apache.org/docs/start/install, but > > that > > > > does > > > > > > not > > > > > > > > > > link to > > > > > > > > > > > > > > any source bundle. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Furthermore, the install page links to nightly > > > > snapshots; > > > > > > this > > > > > > > > is > > > > > > > > > > not > > > > > > > > > > > > > > allowed except on a page intended for Fury > > developers, > > > > who > > > > > > > > should > > > > > > > > > > be > > > > > > > > > > > > > > made aware that nightly code has not been vetted. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Git tag for the release: > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Git commit for the release: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Maven staging repo: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachefury-1003 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > How to Build and Test, please refer to: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours or > > until > > > > the > > > > > > > > > > necessary > > > > > > > > > > > > number > > > > > > > > > > > > > > > of votes is reached. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Please vote accordingly: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [ ] +1 approve > > > > > > > > > > > > > > > [ ] +0 no opinion > > > > > > > > > > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > To learn more about apache fury, please see > > > > > > > > > > https://fury.apache.org/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Checklist for reference: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [ ] Download links are valid. > > > > > > > > > > > > > > > [ ] Checksums and signatures. > > > > > > > > > > > > > > > [ ] LICENSE/NOTICE files exist > > > > > > > > > > > > > > > [ ] No unexpected binary files > > > > > > > > > > > > > > > [ ] All source files have ASF headers > > > > > > > > > > > > > > > [ ] Can compile from source > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Chaokun Yang > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > > > > > > > To unsubscribe, e-mail: > > > > > > > > general-unsubscr...@incubator.apache.org > > > > > > > > > > > > > > For additional commands, e-mail: > > > > > > > > general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > > > > > > To unsubscribe, e-mail: > > > > > > general-unsubscr...@incubator.apache.org > > > > > > > > > > > > > For additional commands, e-mail: > > > > > > > > general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > > > > > To unsubscribe, e-mail: > > > > > > general-unsubscr...@incubator.apache.org > > > > > > > > > > > > For additional commands, e-mail: > > > > > > general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > > > To unsubscribe, e-mail: > > > > general-unsubscr...@incubator.apache.org > > > > > > > > > > For additional commands, e-mail: > > > > general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > To unsubscribe, e-mail: > > general-unsubscr...@incubator.apache.org > > > > > > > > For additional commands, e-mail: > > general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
