Rule #1 from The Elements of Java Style is: Adhere to the style of the original
----- Original Message ----- From: "robert burrell donkin" <[EMAIL PROTECTED]> To: "Jakarta General List" <[EMAIL PROTECTED]> Cc: "Jakarta Commons Developers List" <[EMAIL PROTECTED]> Sent: Friday, January 04, 2002 12:49 PM Subject: Re: More abuse of coding styles... > i'd just like to point out that i didn't write that bit of code (but > neither did i correct it). > > personally speaking, i'm not going to risk having patches vetoed because i > try to correct the original author's coding style. > > any committer who has the time and energy to fight is very welcome to > correct the many deviations from the standards that you'll find in the > commons (and in the other projects as well, no doubt). > - robert > > On Friday, January 4, 2002, at 01:54 AM, Jon Scott Stevens wrote: > > > It is amazing to me...with all the discussion about coding styles and > > following them, we still have people committing code that doesn't follow > > what rules we do have... > > > > on 1/3/02 11:00 AM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > > > > Re: cvs commit: jakarta- > > commons/logging/src/java/org/apache/commons/logging > > SimpleLog.java > > > >> + if(_showtime) { > > > > <http://java.sun.com/docs/codeconv/html/CodeConventions.doc8.html#367> > > > > "Variable names should not start with underscore _ or dollar sign $ > > characters, even though both are allowed." > > > > <http://jakarta.apache.org/site/source.html> > > > > "All Java Language source code in the repository must be written in > > conformance to the "Code Conventions for the Java Programming Language as > > published by Sun." > > > > -jon > > > > > > -- > > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>