On Feb 16, 2015 8:01 AM, "Patrick Lauer" <patr...@gentoo.org> wrote: > > Right now repoman is relatively permissive - it whines about many things, but > treats many issues as warning. > The result is that many ebuilds get committed with 'minor' cosmetic issues > which then someone more OCD than the original committer cleans up, making > pretty much everyone involved more unhappy. > > There's no reason to not error out on, for example, an invalid RESTRICT. Just > printing a message is relatively useless. > > > Thus I suggest making the following warnings proper errors: > > (Taken from current repoman 'qawarnings' set) > > "changelog.missing", > "changelog.notadded", > "digest.assumed", > "digest.unused", > "ebuild.notadded", > "ebuild.nesteddie", > "DESCRIPTION.toolong", > "RESTRICT.invalid", > "ebuild.minorsyn", > "ebuild.badheader", > "metadata.warning", > "LIVEVCS.stable", > "LIVEVCS.unmasked", > > Most of these have few or no occurrences in the current tree, so changing the > default from warn to error won't get in the way of the normal workflow. > > (A few of them, like DESCRIPTION.toolong, still have about a dozen leftovers, > but that should be easy to fix) > > Have fun, > > Patrick >
I would also like to put forward the idea of a pedantic flag, like with GCC, To make all warnings fatal. Or at minimum, make a lesser flag where certain flags that are not normally fatal, would become fatal.
