On Mon, 16 Feb 2015 21:00:16 +0800 Patrick Lauer wrote: > Right now repoman is relatively permissive - it whines about many things, but > treats many issues as warning. > The result is that many ebuilds get committed with 'minor' cosmetic issues > which then someone more OCD than the original committer cleans up, making > pretty much everyone involved more unhappy. > > There's no reason to not error out on, for example, an invalid RESTRICT. Just > printing a message is relatively useless. > > > Thus I suggest making the following warnings proper errors: > > (Taken from current repoman 'qawarnings' set) [...] > "ebuild.minorsyn",
Not this one, please. It gives tons of false warnings, e.g.: ebuild.minorsyn 1 media-video/kino/kino-1.3.4.ebuild: Unquoted Variable on line: 95 It also have problems with nested "\"\"" constructs. I can't remember example right now. > "ebuild.badheader", > "metadata.warning", > "LIVEVCS.stable", > "LIVEVCS.unmasked", > > Most of these have few or no occurrences in the current tree, so changing the > default from warn to error won't get in the way of the normal workflow. > > (A few of them, like DESCRIPTION.toolong, still have about a dozen leftovers, > but that should be easy to fix) I don't see any reasons to make this one fatal. Best regards, Andrew Savchenko
pgpUp8BCODEiO.pgp
Description: PGP signature
