Looks good Andrea. A couple of very minor things: * is there a reason for using String for url's in MarkFactory and and java.net.URL. in ExternalGraphicFactory? I guess perhaps because the ExternalGraphic is indeed *external* and you one needs to grab a connection from it?
* I think the proposal lacks a few simple code examples. For instance the "Alternative design", I think i understand it... but an example would really drive it home. All in all looks great though. Andrea Aime wrote: > Hi, > I've prepared this proposal so that GeoTools can support extensible > symbol sets (for Mark and ExternalGraphic) and dinamically generated > symbols, eventually dependent on feature attributes: > > http://docs.codehaus.org/display/GEOTOOLS/Dynamic+SLD+Graphic+objects > > Please discuss the proposal on the mailing list. I'd also like to > call for a vote into this evening meeting unless anybody finds > anything wrong with it. > > Cheers > Andrea > > ------------------------------------------------------------------------- > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference > Don't miss this year's exciting event. There's still time to save $100. > Use priority code J8TL2D2. > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone > _______________________________________________ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > !DSPAM:4007,48032792273041030819293! > -- Justin Deoliveira The Open Planning Project [EMAIL PROTECTED] ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
