Justin Deoliveira ha scritto: > Looks good Andrea. A couple of very minor things: > > * is there a reason for using String for url's in MarkFactory and and > java.net.URL. in ExternalGraphicFactory? I guess perhaps because the > ExternalGraphic is indeed *external* and you one needs to grab a > connection from it?
Ha ha, touché... it's my laziness. Is "square" a valid URL? I did not check, that's why I kept it a string. If not URL, would it make sense to use URI? > * I think the proposal lacks a few simple code examples. For instance > the "Alternative design", I think i understand it... but an example > would really drive it home. Examples of how a factory would be coded, or how it would be used? Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
