On Tue, Jul 31, 2012 at 5:44 PM, Niels Charlier <ni...@scitus.be> wrote:
> Oops it seems some new files are missing in the patch. My apologies,
> will upload complete patch in a minute.
>
>
Looked at the proposal and the patch, a few questions:
* the proposal should tell how are you addressing the dicotomy between
CoordinateReferenceSystem and the SRS string which is required by the BBOX
interface (the CRS might not have a way to be represented as an SRS)
* ReferencedEnvelope3D extends ReferenceEnvelope (not
ReferenceEnvelope3D)... this is just a typo anyways
* It would be nice to have
ReferencedEnvelope.reference(org.opengis.geometry.Envelope) method building
the proper
ReferencedEnvelope object based on the number of dimensions of the
provided Envelope
* for the trasform method imho a better, but simple implementation would be
to reproject the x,y and leave the Z
unaltered (but preserve it). This is what JTS.tarnsform(Geometry,
MathTransform) does today, so it would also preserve
consistency within the library
* About the usage of the CRS to determine if the dimensions are 3 I have my
doubts... the support for 3D CRS is
not very good in GeoTools, I believe the common usage would be 2d+1 with
a 2d crs with 3 ordinates
* I see BBOX3D is a new type of filter that the stores need to implement
support for. Which means right now we're
going to have full in memory evaluation of these 3d bboxes for all
stores, which is going to be tremendously slow.
* I see no support for building a BBOX3D filter by parsing XML or CQL,
which means there is no real way to use it besides
building it programmatically, how is this going to be handled?
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
