Hi,
I'm sorry if this has irritated people.
The creator of the pull request had not responded to your constructive comments
for some time. (There were incompatible API changes and no unit tests.) If the
changes were important enough to the contributor then I would have felt that a
faster response would have occurred.
It is easy for Pull Request to be reopened. This is also true for Issues in
JIRA.
Maybe this will motivate the contributor to act upon the issue.
What are other peoples thoughts?
Brett
________________________________
From: Andrea Aime [andrea.a...@geo-solutions.it]
Sent: Sunday, 21 July 2013 6:15 PM
To: Geotools-Devel list
Subject: [Geotools-devel] The tension between keeping the house clean and
trying to accept as much contributions as possible
Hi,
this morning I've noticed that a couple of pull requests were closed due to "5
months of inactivity" https://github.com/geotools/geotools/pull/120
At first I thought it was the original author pissed because I did not have a
look at the pull request for such a long time, but then I've noticed that it
was Brett closing the pull request.
Now, I believe I understand the rationale for closing the pull: it has been
there for a long time, there is no activity, it just looks bad and moreover it
does not look like it's going anywhere.
At the same time, in jira we have tickets that are 7+ years old:
http://jira.codehaus.org/issues/?jql=project%20%3D%20GEOT%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20ASC
Also those are not getting anywhere, but I guess they are more tolerable
because they are not as much "in your face" as pull requests.
Also in GeoServer we have a bunch of pull requests that are just sitting there
moving nowhere, mostly because of lack of tests, some because they have
unresolved issues:
https://github.com/geoserver/geoserver/pulls
Given that it's clear between pull requests and jira tickets there is much more
work than we can possibly handle, and given that funding keeps on making us use
working hours on other topics, what do you feel it's the appropriate course of
action?
It seems bad to me to close a pull request that's incomplete or needs fixes,
because there is also good work in there, at the same time, if the original
author does not fix the pull, who will?
Maybe we should link the pull request from the associated jira ticket, and then
close the pull, so that others might take over later?
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
