Andrea Said:
| Maybe we should link the pull request from the associated jira
ticket, and then close the pull, so that others might take over later?
I agree with this sentiment.
Some of my random thoughts regarding pull requests:
Pull request are intimately tied to the code base. That big green button to
merge is compelling at times. Push Me, Push Me... Closing an old (what is
old?) pull request prevents damaging merges from hitting our code base. Jira
tickets don't have this associated risk.
While geotools committers can re-open closed pull requests, I'm unsure if the
original contributor can do this. I think the original contributor cannot, but
it is easy to create a new pull request. Note in the jira ticket if this is the
case
If a jira ticket is not connected to a pull request, then create one.
A pull request has three states: Open, Closed and unmerged, Merged; while a
jira ticket has more detailed state information.
A useful attribute of pull requests that could be used more is the person to
which the pull request is assigned. It is mostly left unassigned. An assigned
person would be a geotools committer. This would prevent toes from being
damaged.
Brett
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
