Attention is currently required from: neels, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 19: (1 comment) File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/499080da_8156c262 PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf))); > I like the idea of supporting both 0x0a and 0x0b in osmo-pcu, that's great. > […] If we go this way (backwards compatibility), we would have to keep both `PCU_IF_MSG_DATA_CNF` and `PCU_IF_MSG_DATA_CNF_DT` as well as both `PCU_IF_SAPI_PCH` and `PCU_IF_SAPI_{AGCH->PCH}_DT` in the protocol definition. There would still be two ways of doing the same thing (sending data over PCH), what renders the idea of bumping the PCUIF version equal to having a flag in the `INFO.ind`. "Here we go again". We could use this version bump chance to clean up the protocol a bit and make life easier for those who will be working on the PCUIF in the future and trying to understand what message does what. I don't really want to block getting this work merged, and will better stop adding even more comments/nitpicks. But I really don't see the benefits of making version 0x0b backwards compatible with 0x0a, given that the patch for osmo-bts is already in Gerrit and upgrading osmo-bsc to 0x0b is not going to take too much effort either... -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 19 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Wed, 01 Mar 2023 22:25:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
