Attention is currently required from: neels, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 19: (6 comments) Patchset: PS19: I see there is a lot of confusion on the backward compatibility topic. I will now look at the BTS patches. I have fixed stuff in other places, so I will push the patch set again. I will get to the remaining comments later. File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/2451598b_6ea9afa7 PS19, Line 279: uint8_t pgroup; > > And AFAIR, yes, it can be bigger than 255. […] I have checked the spec for RSL it is indeed only one octet, see 3GPP TS 08.58 section 9.3.14 File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/d93824b0_9a7f957d PS18, Line 43: PCU_IF_SAPI_PCH_DT > The patch for `osmo-bts.git` is already in Gerrit (currently WIP to avoid > merging before this one). […] I have seen your BTS patch. Thanks. I will test this today. I didn't look at the tests yet. File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/2010506c_ba95065d PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf))); > If we go this way (backwards compatibility), we would have to keep both > `PCU_IF_MSG_DATA_CNF` and `P […] Ack File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/1f63b010_b9763c10 PS19, Line 298: pgroup > I think this is where the confusion comes from. […] Thats wired. https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/4cbb623c_55f60c47 PS19, Line 771: } else { > According to above block (like 752), only PCU_IF_VERSION and 0x0a are allows > to reach here. […] Thats true. I thought that I had remove it though... -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 19 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 14:11:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
