Attention is currently required from: neels, pespin, fixeria.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )

Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
......................................................................


Patch Set 19:

(2 comments)

File include/osmocom/pcu/pcuif_proto.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/311c9ade_8c1ba4a7
PS17, Line 280:         uint8_t pgroup[3];
> So let's provide the SI (if we don't do that already) to osmo-pcu so it can 
> calculate the paging gro […]
I think we should transfer the whole IMSI to osmo-bsc. Then we can correctly 
calculate the paging group there and also log it so that we know who is being 
paged.

After all I am a bit confused. I have compared the paging group calculation 
results with Osmo-BTS and they match up. This also might be coincidence or due 
to the fact that my IMSI ends on 002.


File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/e7d34807_61196383
PS19, Line 771:         } else {
> Thats true. I thought that I had remove it though...
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f
Gerrit-Change-Number: 31145
Gerrit-PatchSet: 19
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: neels <nhofm...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Mar 2023 16:41:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Comment-In-Reply-To: dexter <pma...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to