Attention is currently required from: neels, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 20: (2 comments) File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/21e6ff55_31827fa5 PS17, Line 280: uint8_t pgroup[3]; > I think we should transfer the whole IMSI to osmo-bsc. […] Send whole IMSI to BTS/BSC: fine let's to that. File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/4fbcef59_77987b64 PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf))); > It seems that the discussion is a bit stuck here. I suggest the following > compromise: […] Agree with the first part: Add the new message sending the whole IMSi and keep the backward compatibility in this patch and we will also bump the version number Disagree with the second part: The fact that we still support the older version of the protocol with the older version of the message in osmo-pcu doesn't mean we need to bump the version again to drop the old message. From protocol point of view, the old message doesn't exist anymore after the first bump. It's just an implementation thing of osmo-pcu to keep supporting the older version of the protocol which still uses the old message. Moreover, let's keep this backward compatibility (allow use of older protocol version) for a while to let osmo-pcu work with older osmo-bts for a while. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 20 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Fri, 03 Mar 2023 15:09:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
