Attention is currently required from: dexter, fixeria, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )
Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 13: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/61ccade4_4862c6f7?usp=email : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the > I still don't understand why an abstract class is not inheriting from abc. […] abc has no purpose and it doesn't work. The first time this comment came up, I tried to use abc to determine which ConfigurableParameter classes are abstract. This did not work at all. Adding empty cruft to code is not what I do. This has been my position for a long time now. I am not defending this position to spite reviews, but the logical reason to change the patch is simply not present. I would love to accept your point, but explain to me why exactly you want to see abc in there. If the reason is cosmetic, then let me know. I will disagree and i will still have to use a simple boolean flag to make it work as it should, but then I could at least understand what on earth you mean and why it is so important. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 13 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Wed, 07 Jan 2026 23:23:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
