Attention is currently required from: dexter, laforge, neels, pespin. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )
Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 16: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/700e9523_cd141005?usp=email : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the > re the build failure, dear Vadim, on the contrary. > This is a prime example why we don't need to prevent instantiation. > The apply_val() implementation follows in a separate patch, neatly separated > for readability during CR. I spent time to separate that. If something is not there yet, one can still define a stub like this: ``` def apply_val(cls, pes: ProfileElementSequence, val): raise NotImplementedError # XXX/TODO ``` Anyways, I am not willing/going to block here. "Heightening the misery" is certainly not what I was aiming for. I just shared my understanding of the `abc` stuff in Python and I am sorry if my comments were giving you additional headaches. This is not a project that I am directly involved in and you're not modifying the code that I wrote, so I am bailing out from the review loop of this patchset. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 16 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 15 Jan 2026 22:06:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
