Attention is currently required from: dexter, fixeria, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )
Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 14: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/3aed4a5e_4936a1db?usp=email : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the > > abc has no purpose and it doesn't work. […] I would have liked that my opinion on mini minor aspects would be heard as a useful choice that has been made to save time, and not ridden out over and over until i have to, again, completely give up my entire point -- mind you in disapproval. I will adjust the patch now, which means I will read up on how to use abstract decorators properly, again, to probably conclude, again, that it is not solving any problem of remote relevance to this branch. I will remember, again, that I have never seen it being used in any RL lib or app anywhere. Mixins, inheritance: yes; ABC: no. I have seen a fair share of python and seeing ABC here did not help me, but confused me into ivestiating what is so different here that it needs ABC; turns out, nothing. So why am I adding this? There is for many months now *objectively* no reason to spend any time on this, at all. I will still add it back despite all this, and I am not very happy about it. related: I thought about my is_abstract flag and I think it is a misnomer and still the wrong approach. I will comment about that on the patch adding the is_abstract flag... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 14 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Sun, 11 Jan 2026 02:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]>
