Attention is currently required from: dexter, fixeria, laforge, pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )
Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 15: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/15931b3a_b0426ffe?usp=email : PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the > Guys, think before jumping on the scrum. […] re the build failure, dear Vadim, on the contrary. This is a prime example why we don't need to prevent instantiation. The apply_val() implementation follows in a separate patch, neatly separated for readability during CR. I spent time to separate that. Now we have ABC sliding in the way, telling us that, no, we cannot even run the test suite because there seems to be an incomplete class. Which is, surprise, in development, and expected to be as yet incomplete. I have unit tests for the Pin1 class to tell me whether it works. I do explicitly not need the build to fail before the test can even run. There is no mixup of apply() and apply_val(), the one is the instance-method and the other the class-method. This is simply more and more delay from discussing fringe language evangelisms for months on end. I hope to get to fixing errors any day now, maximally annoying CR situation here, and you are all tuning in to heighten the misery. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 15 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 15 Jan 2026 04:37:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
