Attention is currently required from: dexter, laforge, neels.

pespin has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )

Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi
......................................................................


Patch Set 15:

(1 comment)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/39742/comment/a298d06b_1c3273fc?usp=email :
PS13, Line 50:     r"""Base class representing a part of the eSIM profile that 
is configurable during the
> > abc has no purpose and it doesn't work. […]
While I'm not a python expert, I agree with fixeria and laforge here, I think 
fixeria wrote down quite well my thoughts on it.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8
Gerrit-Change-Number: 39742
Gerrit-PatchSet: 15
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 12 Jan 2026 10:17:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to