westonpace commented on a change in pull request #9323: URL: https://github.com/apache/arrow/pull/9323#discussion_r568264983
########## File path: cpp/src/arrow/compute/api_vector.h ########## @@ -296,7 +315,8 @@ Result<std::shared_ptr<StructArray>> ValueCounts(const Datum& value, /// \since 1.0.0 /// \note API not yet finalized ARROW_EXPORT -Result<Datum> DictionaryEncode(const Datum& data, ExecContext* ctx = NULLPTR); +Result<Datum> DictionaryEncode(const Datum& data, const DictionaryEncodeOptions& options, Review comment: Done, and cleaned up all the other call sites explicitly stating the default options. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org