westonpace commented on a change in pull request #9323:
URL: https://github.com/apache/arrow/pull/9323#discussion_r580558289
##########
File path: cpp/src/arrow/compute/kernels/vector_hash.cc
##########
@@ -687,11 +738,14 @@ void RegisterVectorHash(FunctionRegistry* registry) {
// ----------------------------------------------------------------------
// dictionary_encode
+ const auto kDefaultDictionaryEncodeOptions =
DictionaryEncodeOptions::Defaults();
Review comment:
Done.
##########
File path: cpp/src/arrow/dataset/expression.h
##########
@@ -135,6 +135,9 @@ inline bool operator!=(const Expression& l, const
Expression& r) { return !l.Equ
ARROW_DS_EXPORT
Expression literal(Datum lit);
+ARROW_DS_EXPORT
+Expression null_literal(const std::shared_ptr<DataType>& type);
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
