westonpace commented on a change in pull request #9323:
URL: https://github.com/apache/arrow/pull/9323#discussion_r568266523
##########
File path: cpp/src/arrow/compute/kernels/vector_hash.cc
##########
@@ -451,8 +487,12 @@ struct HashKernelTraits<Type, Action,
enable_if_has_string_view<Type>> {
template <typename Type, typename Action>
std::unique_ptr<HashKernel> HashInitImpl(KernelContext* ctx, const
KernelInitArgs& args) {
using HashKernelType = typename HashKernelTraits<Type, Action>::HashKernel;
- auto result =
::arrow::internal::make_unique<HashKernelType>(args.inputs[0].type,
-
ctx->memory_pool());
+ DictionaryEncodeOptions options;
+ if (auto options_ptr = static_cast<const
DictionaryEncodeOptions*>(args.options)) {
Review comment:
I moved the options decoding into Action although the `HashKernel` still
needed to be aware of it (to decide if `null` should go in the dictionary or
not) so it changed the kernel->action interface slightly (added
`ShouldEncodeNulls`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
