westonpace commented on a change in pull request #9323:
URL: https://github.com/apache/arrow/pull/9323#discussion_r580559082
##########
File path: cpp/src/arrow/dataset/partition_test.cc
##########
@@ -322,8 +397,9 @@ TEST_F(TestPartitioning, DiscoverHiveSchema) {
}
Review comment:
There was already one in dictionary inference but I added one in the
non-dictionary inference case too. This also prompted me to consider the case
`{"/alpha=_FALLBACK_STRING_"}` which I've changed to be an error instead of
returning an empty schema. This matches directory partitioning.
##########
File path: cpp/src/arrow/dataset/partition.h
##########
@@ -120,6 +125,7 @@ class ARROW_DS_EXPORT KeyValuePartitioning : public
Partitioning {
/// of a scalar value
struct Key {
std::string name, value;
+ bool null;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
