westonpace commented on a change in pull request #9323: URL: https://github.com/apache/arrow/pull/9323#discussion_r575453002
########## File path: python/pyarrow/tests/test_dataset.py ########## @@ -1587,33 +1587,54 @@ def test_open_dataset_non_existing_file(): @pytest.mark.parquet @pytest.mark.parametrize('partitioning', ["directory", "hive"]) +@pytest.mark.parametrize('null_fallback', ['xyz', None]) Review comment: In that case it does not pass in anything when it creates the partitioning and ensures that it defaults to the correct default value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org