adamreeve commented on PR #7111: URL: https://github.com/apache/arrow-rs/pull/7111#issuecomment-2756055877
> I came up with https://github.com/apache/arrow-rs/pull/7337 which I think is easier to work with Thanks, this example helped. I took another pass at refactoring `ThriftMetadataWriter` and this is much nicer now. > Since this is a major release, we can make API changes too if needed to support modular encryption. The one thing that comes to mind is whether we want to change `AsyncArrowWriter::finish` to return `parquet::file::ParquetMetadata` instead of `parquet::format::FileMetaData`. This was suggested in #7254 although closed without comment, but that would probably avoid the problem of writers not being able to use the returned metadata to retrieve statistics due to them being encrypted (https://github.com/apache/arrow-rs/pull/7111/files#r2009421835). But that might be quite a large and painful breaking change, and also might come with a performance hit... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
