adamreeve commented on code in PR #7111:
URL: https://github.com/apache/arrow-rs/pull/7111#discussion_r2020258059
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -727,85 +819,173 @@ pub fn get_column_writers(
) -> Result<Vec<ArrowColumnWriter>> {
let mut writers = Vec::with_capacity(arrow.fields.len());
let mut leaves = parquet.columns().iter();
+ let column_factory = ArrowColumnWriterFactory::new();
for field in &arrow.fields {
- get_arrow_column_writer(field.data_type(), props, &mut leaves, &mut
writers)?;
+ column_factory.get_arrow_column_writer(
+ field.data_type(),
+ props,
+ &mut leaves,
+ &mut writers,
+ )?;
}
Ok(writers)
}
-/// Gets the [`ArrowColumnWriter`] for the given `data_type`
-fn get_arrow_column_writer(
- data_type: &ArrowDataType,
+/// Returns the [`ArrowColumnWriter`] for a given schema and supports columnar
encryption
+#[cfg(feature = "encryption")]
+fn get_column_writers_with_encryptor(
Review Comment:
:+1: I've made https://github.com/apache/arrow-rs/issues/7359 for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
