adamreeve commented on PR #54884: URL: https://github.com/apache/arrow/pull/54884#issuecomment-6352237621
> So a proper fix looks IMHO like this: Yes, agreed. It looks like this PR is a partial fix, it correctly sets the file metadata's `encryption_algorithm`, fixing the issue reported in #51669 and allowing round-tripping within this library. But the files are still incompatible with the spec due to using the file algorithm for footer signing rather than always using AES-GCM. I also agree with dropping any modifications to `signing_algorithm.aad`, this should be set correctly already here: https://github.com/apache/arrow/blob/14132604b3949ba1c25cc79fff2e1782b9efc413/cpp/src/parquet/encryption/encryption.cc#L328-L332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
