adamreeve commented on PR #54884: URL: https://github.com/apache/arrow/pull/54884#issuecomment-6355524159
> I checked the old code too: metadata=true already selects GCM, and SignedFooterEncrypt rejects CTR. The new footer tag test also passes on the previous head. So the behavior fix is the metadata value; the GCM calls just make the signing rule clear. It took me a while to parse this AI speak, but I think this is saying that changing `file_decryptor->algorithm()` to `ParquetCipher::AES_GCM_V1` isn't actually necessary. We end up doing AES-GCM by passing `metadata=True`, which I missed: https://github.com/apache/arrow/blob/14132604b3949ba1c25cc79fff2e1782b9efc413/cpp/src/parquet/encryption/encryption_internal.cc#L76 Passing the AES_GCM_V1 algorithm explicitly makes things clearer. But this is more evidence for a tidy up being necessary (#45525). I'm happy to create a new parquet-testing file for this. I think we should generate it from this PR branch, then verify it can be read in arrow-go and parquet-java (which are the only other implementations that support AES-CTR I believe). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
