autoCAT6 commented on PR #54884: URL: https://github.com/apache/arrow/pull/54884#issuecomment-6433536192
Thanks, both issues are fixed. The key length now has an explicit `int32_t` conversion, and the test constructs the same footer AAD locally from the file AAD and footer module byte, so `CreateFooterAad` does not need to be exported. The test translation unit passes `-Werror=shorten-64-to-32`, its object no longer references `CreateFooterAad`, and all 45 encryption tests pass against the shared libraries on macOS. The on-disk GCM tag check is unchanged. Windows still needs CI confirmation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
