adamreeve commented on PR #54884:
URL: https://github.com/apache/arrow/pull/54884#issuecomment-6432441176
Can you please check the build failures @autoCAT6:
```
FAILED:
src/parquet/CMakeFiles/parquet-encryption-test.dir/encryption/write_configurations_test.cc.o
/usr/bin/ccache /usr/bin/clang++-18 -DADDRESS_SANITIZER
-DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2
-DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_UBSAN
-DPARQUET_THRIFT_VERSION_MAJOR=0 -DPARQUET_THRIFT_VERSION_MINOR=19
-DSIMDJSON_DEVELOPMENT_CHECKS -DSIMDJSON_EXCEPTIONS=0
-DSIMDJSON_THREADS_ENABLED=1 -I/build/cpp/src -I/arrow/cpp/src -isystem
/build/cpp/_deps/xsimd-src/include -isystem
/arrow/cpp/thirdparty/flatbuffers/include -isystem
/build/cpp/_deps/simdjson-src/include -Qunused-arguments -fcolor-diagnostics
-Wall -Wextra -Wdocumentation -DARROW_WARN_DOCUMENTATION -Wshorten-64-to-32
-Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand
-Wno-return-stack-address -Wdate-time -Wno-unknown-warning-option
-Wno-pass-failed -msse4.2 -fsanitize=address -DADDRESS_SANITIZER
-fsanitize=undefined -fno-sanitize=alignment,vptr,function,float-divide-by-zero
-fno-sanitize-recover=all -fsanitize-coverage=pc-table,inline-8bit-coun
ters,edge,no-prune,trace-cmp,trace-div,trace-gep
-fsanitize-blacklist=/arrow/cpp/build-support/sanitizer-disallowed-entries.txt
-g -Werror -O0 -ggdb -g1 -std=c++20 -fPIE
-fsanitize-coverage=pc-table,inline-8bit-counters,edge,no-prune,trace-cmp,trace-div,trace-gep
-DGTEST_HAS_PTHREAD=1 -MD -MT
src/parquet/CMakeFiles/parquet-encryption-test.dir/encryption/write_configurations_test.cc.o
-MF
src/parquet/CMakeFiles/parquet-encryption-test.dir/encryption/write_configurations_test.cc.o.d
-o
src/parquet/CMakeFiles/parquet-encryption-test.dir/encryption/write_configurations_test.cc.o
-c /arrow/cpp/src/parquet/encryption/write_configurations_test.cc
/arrow/cpp/src/parquet/encryption/write_configurations_test.cc:292:62:
error: implicit conversion loses integer precision: 'std::size_t' (aka
'unsigned long') to 'int32_t' (aka 'int') [-Werror,-Wshorten-64-to-32]
291 | auto encryptor = AesEncryptor::Make(ParquetCipher::AES_GCM_V1,
| ~~~~~~~~~~~~
292 | kFooterEncryptionKey.size(),
/*metadata=*/true,
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~
```
```
FAILED: [code=4294967295] debug/parquet-encryption-test.exe
C:\Windows\system32\cmd.exe /C "cd . && "C:\Program
Files\Git\usr\bin\cmake.exe" -E vs_link_exe --msvc-ver=1944
--intdir=src\parquet\CMakeFiles\parquet-encryption-test.dir
--rc=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x64\rc.exe
--mt=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x64\mt.exe --manifests --
C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\link.exe
/nologo @CMakeFiles\parquet-encryption-test.rsp
/out:debug\parquet-encryption-test.exe
/implib:debug\parquet-encryption-test.lib
/pdb:debug\parquet-encryption-test.pdb /version:0.0 /machine:x64
/NODEFAULTLIB:LIBCMT /debug /INCREMENTAL /subsystem:console && cd ."
LINK Pass 1: command
"C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\link.exe
/nologo @CMakeFiles\parquet-encryption-test.rsp
/out:debug\parquet-encryption-test.exe
/implib:debug\parquet-encryption-test.lib
/pdb:debug\parquet-encryption-test.pdb /version:0.0 /machine:x64
/NODEFAULTLIB:LIBCMT /debug /INCREMENTAL /subsystem:console /MANIFEST
/MANIFESTFILE:src\parquet\CMakeFiles\parquet-encryption-test.dir/intermediate.manifest
src\parquet\CMakeFiles\parquet-encryption-test.dir/manifest.res" failed (exit
code 1120) with the following output:
unity_0_cxx.cxx.obj : error LNK2019: unresolved external symbol "class
std::basic_string<char,struct std::char_traits<char>,class std::allocator<char>
> __cdecl parquet::encryption::CreateFooterAad(class
std::basic_string<char,struct std::char_traits<char>,class std::allocator<char>
> const &)"
(?CreateFooterAad@encryption@parquet@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV34@@Z)
referenced in function "protected: void __cdecl
parquet::encryption::test::TestGeneratedEncryptionConfiguration::CheckPlaintextFooterSignature(void)"
(?CheckPlaintextFooterSignature@TestGeneratedEncryptionConfiguration@test@encryption@parquet@@IEAAXXZ)
debug\parquet-encryption-test.exe : fatal error LNK1120: 1 unresolved
externals
```
Because you're calling `CreateFooterAad` from a test it will need to be
annotated with `PARQUET_EXPORT`. Or maybe it's OK to use an arbitrary AAD in
the test to avoid needing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
