jayzhan211 commented on code in PR #10651:
URL: https://github.com/apache/datafusion/pull/10651#discussion_r1616206126
##########
datafusion/physical-expr-common/src/aggregate/mod.rs:
##########
@@ -375,37 +406,41 @@ impl AggregateExpr for AggregateFunctionExpr {
}
fn reverse_expr(&self) -> Option<Arc<dyn AggregateExpr>> {
- if let Some(reverse_udf) = self.fun.reverse_udf() {
- let reverse_ordering_req = reverse_order_bys(&self.ordering_req);
- let reverse_sort_exprs = self
- .sort_exprs
- .iter()
- .map(|e| {
- if let Expr::Sort(s) = e {
- Expr::Sort(s.reverse())
- } else {
- // Expects to receive `Expr::Sort`.
- unreachable!()
- }
- })
- .collect::<Vec<_>>();
- let mut name = self.name().to_string();
- replace_order_by_clause(&mut name);
- replace_fn_name_clause(&mut name, self.fun.name(),
reverse_udf.name());
- let reverse_aggr = create_aggregate_expr(
- &reverse_udf,
- &self.args,
- &reverse_sort_exprs,
- &reverse_ordering_req,
- &self.schema,
- name,
- self.ignore_nulls,
- self.is_distinct,
- )
- .unwrap();
- return Some(reverse_aggr);
+ match self.fun.reverse_udf() {
+ ReversedUDAF::NotSupported => None,
+ ReversedUDAF::Identical => Some(Arc::new(self.clone())),
Review Comment:
We need cloned for Identical, previous code does reversing for Identical,
which is incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
