jayzhan211 commented on code in PR #10651:
URL: https://github.com/apache/datafusion/pull/10651#discussion_r1619693831
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -75,7 +75,8 @@ impl FirstValue {
vec![
// TODO: we can introduce more strict signature that only
numeric of array types are allowed
TypeSignature::ArraySignature(ArrayFunctionSignature::Array),
- TypeSignature::Uniform(1, NUMERICS.to_vec()),
+ TypeSignature::Numeric(1),
+ TypeSignature::Uniform(1, vec![DataType::Utf8]),
Review Comment:
This is for numeric string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
